Postgres Pro
Downloads
Home   >   mailing lists

Re: Inaccurate error message when set fdw batch_size to 0 - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Inaccurate error message when set fdw batch_size to 0
Date
Msg-id CAFiTN-vNAVhsNH52XXMM9Dhs+WQHZ+KAHXVghsp-9QFapg37qg@mail.gmail.com
Whole thread Raw
In response to Inaccurate error message when set fdw batch_size to 0  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
List pgsql-hackers
Tree view 
On Sat, May 8, 2021 at 9:09 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> The error message here seems not accurate, because
>
> I can see from the code batch_size should be positive ( > 0).
>

> So, is it better to change the error message to “fetch_size requires a positive integer value” ?
>
> I also found fetch_size has the similar issue, attaching a patch to fix this.

Yes, it should be a positive integer, so your change makes sense.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: Small issues with CREATE TABLE COMPRESSION
Next
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: Enhanced error message to include hint messages for redundant options error