Re: [BUG] "FailedAssertion" reported when streaming in logical replication - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: [BUG] "FailedAssertion" reported when streaming in logical replication
Date
Msg-id CAFiTN-v9vk-q9jfU1g396b=CdJOzm3gy=912dmF4xXF_DsH36w@mail.gmail.com
Whole thread Raw
In response to Re: [BUG] "FailedAssertion" reported when streaming in logical replication  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Thu, Apr 29, 2021 at 5:24 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Apr 27, 2021 at 5:18 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> >
> > I have modified the patch based on the above comments.
> >
>
> The patch looks good to me. I have slightly modified the comments and
> commit message. See, what you think of the attached? I think we can
> leave the test for this as there doesn't seem to be an easy way to
> automate it.

Your changes look good to me.


-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Use simplehash.h instead of dynahash in SMgr
Next
From: Dilip Kumar
Date:
Subject: Re: Enhanced error message to include hint messages for redundant options error