Downloads
Home   >   mailing lists

Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly
Date
Msg-id CAFiTN-uikqkJ39B4W5zxfQ9M+y8n8M4kHhXo6E9h0-vm2aWV4w@mail.gmail.com
Whole thread Raw
In response to Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly  (Alexander Korotkov <aekorotkov@gmail.com>)
List pgsql-hackers
Tree view 
On Thu, Jun 26, 2025 at 3:20 AM Alexander Korotkov <aekorotkov@gmail.com> wrote:
>
> On Wed, Jun 25, 2025 at 11:25 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> > On Wed, Jun 25, 2025 at 1:18 PM Hayato Kuroda (Fujitsu)
> > <kuroda.hayato@fujitsu.com> wrote:
> > > Another idea is to call ReplicationSlotsComputeRequiredLSN() when at least one
> > > of the restart_lsn is updated, like attached. I feel this could reduce the computation
> > > bit more.
> >
> > Right, that makes sense, if there is nothing updated on disk then we
> > can avoid computing this.
>
> Good idea.  But I think we should associate the "updated" flag
> directly to the fact that one slot (no matter logical or physical)
> changed its last_saved_restart_lsn.  See the attached patch.  I'm
> going to push it if no objections.
>

Looks good to me.


--
Regards,
Dilip Kumar
Google

pgsql-hackers by date:

Previous
From: Yugo Nagata
Date:
Subject: Re: Extend COPY FROM with HEADER to skip multiple lines
Next
From: ikedarintarof
Date:
Subject: Re: Suggestion to add --continue-client-on-abort option to pgbench