Re: Include schema-qualified names in publication error messages. - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Include schema-qualified names in publication error messages.
Date
Msg-id CAFiTN-uF3X5TQPEUdz5oA3BnK7two36YJdBmkvow2zQCaSyYJA@mail.gmail.com
Whole thread
In response to Re: Include schema-qualified names in publication error messages.  ("Euler Taveira" <euler@eulerto.com>)
List pgsql-hackers
On Thu, 30 Apr 2026 at 7:14 PM, Euler Taveira <euler@eulerto.com> wrote:


On Thu, Apr 30, 2026, at 4:37 AM, Dilip Kumar wrote:
>
> Yeah we may, but I feel what we have now looks more readable.
>

My suggestion is that this function should be available in a central place.
That's not the only place that could use qualified schema and relation. If you
search for get_namespace_name_or_temp you will notice that this code path is
repeated in other parts of the code too (see ruleutils.c). It would be good if
we can have a common path for it. Maybe the signature has to be
get_qualified_relname(Oid) to accommodate 

IMHO it’s not a good idea to use Oid when you already have reldesc.

Dilip

pgsql-hackers by date:

Previous
From: "Euler Taveira"
Date:
Subject: Re: Include schema-qualified names in publication error messages.
Next
From: Hannu Krosing
Date:
Subject: Re: Support logical replication of DDLs, take2