Re: Fastpath while arranging the changes in LSN order in logical decoding - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Fastpath while arranging the changes in LSN order in logical decoding
Date
Msg-id CAFiTN-sp701wvzvnLQJGk7JDqrFM8f--97-ihbwkU8qvn=p8nw@mail.gmail.com
Whole thread Raw
In response to Re: Fastpath while arranging the changes in LSN order in logical decoding  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Fastpath while arranging the changes in LSN order in logicaldecoding  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Tue, Mar 24, 2020 at 6:16 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Mon, Mar 9, 2020 at 11:07 PM Andres Freund <andres@anarazel.de> wrote:
> >
> > On 2020-03-07 11:15:27 +0530, Dilip Kumar wrote:
> > > IMHO, if we conclude that because there is no performance gain so we
> > > don't want to add one extra path in the code then we might want to
> > > remove that TODO from the code so that we don't spend time for
> > > optimizing this in the future.
> >
> > +1
> >
>
> Dilip, are you planning to do more tests for this?  Anyone else wants
> to do more tests? If not, based on current results, we can remove that
> TODO and in future, if someone comes with a test case to show benefit
> for adding fastpath, then we can consider the patch proposed by Dilip.

IMHO, I have tried the best case but did not see any performance gain
so I am not planning to test this further.  I have attached the patch
for removing the TODO.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: error context for vacuum to include block number
Next
From: Dean Rasheed
Date:
Subject: Re: Additional improvements to extended statistics