Re: [PG-11] Potential bug related to INCLUDE clause of CREATE INDEX - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: [PG-11] Potential bug related to INCLUDE clause of CREATE INDEX
Date
Msg-id CAFiTN-sou6OTmQewWLxXu4EgMq1Yf3-O-xZHBfC8X30PYWNr+A@mail.gmail.com
Whole thread Raw
In response to [PG-11] Potential bug related to INCLUDE clause of CREATE INDEX  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgsql-hackers
On Tue, Jul 10, 2018 at 6:37 PM, Aditya Toshniwal
<aditya.toshniwal@enterprisedb.com> wrote:
> Hi Dave,
>
> I am working on a feature to support INCLUDE clause of index in PG-11. As
> per the documentation
> https://www.postgresql.org/docs/11/static/sql-createindex.html, columns
> listed in INCLUDE clause cannot also be present as index key columns. But I
> find different behaviour for below queries which are logically identical.
>

>
> CREATE INDEX ind1
>     ON public.some_table USING btree
>     (id asc nulls last)
>     INCLUDE(id)
>     TABLESPACE pg_default;
>
> This query passes and index is created.
>
> Kindly let me know if I am missing anything.
>

Seems like a bug to me.  I think the problem is while checking whether
the INCLUDE column intersects with the index key or not it will
compare the "IndexElem" of INCLUDE with the "IndexElem" of the index
key.  So if any field of the "IndexElem" is not same then it will be
considered as non-intersecting and in this example, the ORDER is not
matching.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: [HACKERS] WAL logging problem in 9.4.3?
Next
From: Alexander Kuzmenkov
Date:
Subject: Re: [HACKERS] PoC: full merge join on comparison clause