Re: Question on error code selection in conflict detection - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Question on error code selection in conflict detection
Date
Msg-id CAFiTN-sipn4VVKqwZKBrXptrY-YOOFnn1ZKZNwNdnOB52NVqCA@mail.gmail.com
Whole thread Raw
In response to Re: Question on error code selection in conflict detection  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Tue, Jun 10, 2025 at 1:25 AM Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Mon, Jun 9, 2025 at 9:45 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> > I was reviewing the code for conflict reporting and became curious
> > about the choice of ERRCODE_T_R_SERIALIZATION_FAILURE. This error code
> > typically signifies a serialization failure within a transaction under
> > serializable isolation, so its use here for a different type of
> > conflict seems somewhat out of place. I did notice its use in other
> > contexts for recovery conflicts in physical replication, which also
> > struck me as a bit unusual.
> >
> > Given these observations, I'm wondering if it would be more
> > appropriate to introduce a new, more specific error code for this
> > purpose?
>
> Makes sense to me. I'm not sure if we should use a new error code or
> some other existing one, but conflating other things with serializable
> failures seems like a bad plan.

Yeah we may use existing as well if we find some appropriate error codes.

--
Regards,
Dilip Kumar
Google



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: queryId constant squashing does not support prepared statements
Next
From: Dilip Kumar
Date:
Subject: Re: Question on error code selection in conflict detection