Re: CHECKPOINT unlogged data - Mailing list pgsql-hackers

On Thu, Jul 10, 2025 at 9:31 AM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>
>
>
> On 2025/07/10 4:26, Nathan Bossart wrote:
> > Here is what I have staged for commit, which I'm planning to do on Friday.
>
> Thanks for updating the patches!
>
> Regarding the 0005 patch:
>
> -                       COMPLETE_WITH("MODE");
> +                       COMPLETE_WITH("MODE, FLUSH_UNLOGGED");
>
> Shouldn't that be:
>
>      COMPLETE_WITH("MODE", "FLUSH_UNLOGGED");
>
> IOW, the two options should be separate strings, so it needs
> double quotes around each.

I agree that it makes more sense to treat them as 2 separate strings.

--
Regards,
Dilip Kumar
Google