Re: Proposal: Conflict log history table for Logical Replication - Mailing list pgsql-hackers

On Mon, Jul 6, 2026 at 3:48 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> On Mon, Jul 6, 2026 at 3:27 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Mon, Jul 6, 2026 at 1:14 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> > >
> > > On Fri, Jul 3, 2026 at 5:25 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
> > > >
> > > > For the pushed patch (commit a5918fd), it seems we missed updating the
> > > > pg_subscription catalog documentation for the two newly added columns:
> > > >
> > > > subconflictlogrelid | oid  |           | not null |
> > > > subconflictlogdest  | text | C         | not null |
> > > >
> > > > Attached is a small patch for the same.
> > >
> > > Yeah that make sense, also added a extra change suggested by Peter for
> > > <firstterm> markup.
> > >
> >
> > Did you consider changing the code comments as suggested by me in
> > email [1] to address Peter's complaint on repetitiveness of code
> > comments?
> >
> > [1] - https://www.postgresql.org/message-id/CAA4eK1LH9N80WbFe88Lp0fFrXosVpYnh8iqtrh9kpfJR5N%3Dpyg%40mail.gmail.com
> >
>
> Not yet, I thought we hadn't reached a conclusion on this part.

Here is the updated version which includes this suggestion. Peter,
does this address your concern about repetitive comments?

--
Regards,
Dilip Kumar
Google