Re: pgAdmin 4 commit: Fix test assertion. - Mailing list pgadmin-hackers

It fails because the test was broken and has never been fixed.  

Rob 

On Jul 31, 2017 8:03 PM, "Murtuza Zabuawala" <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Robert,

I have the latest pull and still this test is fails every time on my machine, not sure if it is because of Python3.6.

On Mon, Jul 31, 2017 at 5:27 PM, Robert Eckhardt <reckhardt@pivotal.io> wrote:

This was broken when the clear button and the edit button were changed to drop downs.  Happened a few weeks ago.  

Rob 

On Jul 31, 2017 6:51 PM, "Murtuza Zabuawala" <murtuza.zabuawala@enterprisedb.com> wrote:

Hi All,

When I run the feature tests, the gives test always fails ( 'query_tool_journey_test.py'),

Python: 3.6 (64-bit)

Platform: OS X (10.10.5)

Am I the only one who gets this error?

======================================================================

ERROR: runTest (pgadmin.feature_tests.query_tool_journey_test.QueryToolJourneyTest)

Tests the path through the query tool

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py", line 46, in runTest

    self._test_history_tab()

  File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py", line 104, in _test_history_tab

    query_we_need_to_scroll_to

  File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py", line 141, in _assert_not_clickable_because_out_of_view

    self.assertRaises(self.page.click_element(element))

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/unittest/case.py", line 728, in assertRaises

    return context.handle('assertRaises', args, kwargs)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/unittest/case.py", line 158, in handle

    (name, self._base_type_str))

TypeError: assertRaises() arg 1 must be an exception type or tuple of exception types

----------------------------------------------------------------------

Ran 10 tests in 359.301s

FAILED (errors=1, skipped=1)

======================================================================

Test Result Summary

======================================================================

PG_95:

8 tests passed

1 test failed:

QueryToolJourneyTest (Tests the path through the query tool)

1 test skipped:

CheckDebuggerForXssFeatureTest (Tests to check if Debugger is vulnerable to XSS)

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 21, 2017 at 8:46 PM, Dave Page <dpage@pgadmin.org> wrote:

Fix test assertion.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ebb409999819534d79376a577a149a8a5db124b
Author: Sarah McAlear <smcalear@pivotal.io>

Modified Files
--------------
web/pgadmin/feature_tests/query_tool_journey_test.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)