Re: [pgAdmin4][RM2586] Cleanup feature test - Mailing list pgadmin-hackers
| From | Harshal Dhumal |
|---|---|
| Subject | Re: [pgAdmin4][RM2586] Cleanup feature test |
| Date | |
| Msg-id | CAFiP3vyN9s7XgUJ7+bQbLmzoZ_6QC_v4pJpZg6SRZQjfS1OAxw@mail.gmail.com Whole thread Raw |
| In response to | Re: [pgAdmin4][RM2586] Cleanup feature test (Sarah McAlear <smcalear@pivotal.io>) |
| Responses |
Re: [pgAdmin4][RM2586] Cleanup feature test
|
| List | pgadmin-hackers |
Hi,
Last week Sarah, Matt and I had call regarding some issues with feature test cases.
For example in auto commit disable test scenario from query tool test cases by removing code line
self.page.find_by_id("btn-auto-commit").click() the test case scenario was not falling.
This issue was due to previously on going database transaction. This issue was also with test scenarios like
auto commit enable and auto rollback enabled. The attached patch fixes this issue.
@Sarah and Matt can you please give this patch a try to check if issues we discussed last week are fixed.
Thanks,
Harshal
--
Harshal Dhumal
Sr. Software Engineer
On Fri, Aug 11, 2017 at 11:55 AM, Sarah McAlear <smcalear@pivotal.io> wrote:
Great job on cleaning up the whole feature test suite! This is really going to benefit all of the developers a lot.Thanks,
Matt & SarahOn Fri, Aug 11, 2017 at 12:24 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached updated patch. In this patch I have removed unused imports.Regarding ajax calls on slow network/computer I have already taken care of those.Before sending first version of patch I tested this on Murtuza's machine and alsotested on slow machine as well.Thanks,Harshal--Harshal DhumalSr. Software EngineerOn Mon, Aug 7, 2017 at 8:55 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi Harshal!There are a few files in which there are leftover imports that are not needed anymore:
- PGDataypeFeatureTest
- PgadminPage
- CheckForXssFeatureTest
- CheckDebuggerForXssFeatureTest
We also noticed that there were quite a few time.sleep functions that were removed. This seems great overall, but we think that some of them were in place because of varying network and computer speeds. So for example, in QueryToolFeatureTest, there is an ajax call that was followed by a time.sleep to ensure that it had finished executing before continuing to execute. Removing this may reintroduce some flakiness. If there are no issues with flakiness after this patch, it seems like a great idea. We ran the tests a few times and didn't notice any flakiness, but we're unsure if it will be a problem on a different system.Thanks!
Wenlin & SarahOn Wed, Aug 2, 2017 at 9:32 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached patch to improve feature test execution time.Now on my machine overall execution time is cut down to 280 seconds from 400+ secondsChanges:1. Removed fixed python time.sleeps where ever possible.2. Removed connect to server test cases.3. Query tool test cases:i. Merged 3 test cases On demand result on scroll, grid select all and column select all.ii. Merged 3 test cases Explain query, Explain query with verbose and Explain query with cost.iii. Merged 3 test cases Explain analyze query, Explain analyze with buffers and Explain analyze with timing.4. Improved debugger XSS test case execution time.--Harshal DhumalSr. Software Engineer
Attachment
pgadmin-hackers by date: