Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation - Mailing list pgadmin-hackers

From Harshal Dhumal
Subject Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation
Date
Msg-id CAFiP3vyCZ7OZ8o1p7Z79jGD8omB5P8n7bE9L8vX0dQoPZwNbdQ@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
Responses Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi,

Please find attached updated patch.
In this patch I have fixed two issues:
i. Dialog tab navigation should work even if focus is on footer buttons (Save, Cancel, etc..)
ii. Focus should be set to first editable element of dialog when tab cycle goes through all editable footer buttons.


-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
This patch fixes Dialog tabset keyboard navigation.
This regression was caused due to bootstrap 4 changes.
Also I have added jasmine test cases for the same


-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][RM3453] Incomplete SQL for Foreign tables in SQL tab
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed execution time to show Hours part for longrunn