Re: RM3079 fix for wrong sql datetime/time related datatypes - Mailing list pgadmin-hackers

From Harshal Dhumal
Subject Re: RM3079 fix for wrong sql datetime/time related datatypes
Date
Msg-id CAFiP3vxELyjKv3LRoLP66g_FPGA_ajdSA6Rai-vZmgUJwpCfrA@mail.gmail.com
Whole thread Raw
In response to Re: RM3079 fix for wrong sql datetime/time related datatypes  (Dave Page <dpage@pgadmin.org>)
Responses Re: RM3079 fix for wrong sql datetime/time related datatypes  (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>)
List pgadmin-hackers
Hi,

On Tue, Feb 27, 2018 at 8:54 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, Feb 27, 2018 at 2:36 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

Please find patch to fix wrong sql issue for time related type.

Steps to reproduce:

Alter any time/datetime array related data type, it generates sql with addition array bracket

Inline image 1

This seems to be missing the test case that you noted should be included in the original bug report! 

Please find updated patch with test cases. 


Thanks,

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
Next
From: Khushboo Vashi
Date:
Subject: Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query