Postgres Pro
Downloads
Home   >   mailing lists

Re: Subnode grid row close issue [pgAdmin4] - Mailing list pgadmin-hackers

From Harshal Dhumal
Subject Re: Subnode grid row close issue [pgAdmin4]
Date
Msg-id CAFiP3vxBkM1barzuJtSXUisHDY6s9aGdZdXxmfcCR-5s-KhBDg@mail.gmail.com
Whole thread Raw
In response to Re: Subnode grid row close issue [pgAdmin4]  (Dave Page <dpage@pgadmin.org>)
Responses Re: Subnode grid row close issue [pgAdmin4]
List pgadmin-hackers
Tree view
Hi,

Here is updated patch.

In initial patch I fixed this issue in only Subnode control while Type node uses unique collection control (which is special case of subnode control). Now I have fixed in both control.



-- 
Harshal Dhumal
Software Engineer 




On Thu, Mar 17, 2016 at 6:41 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Mar 17, 2016 at 11:14 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for Subnode grid row close issue.

Issue fixed:

1] Close any existing row while adding new row.
2] Close any existing row if we edit new row.

This doesn't appear to make any difference to me. I've confirmed the patch is applied, restarted the app, emptied my cache and reloaded, and tested with composite types on the Create Type dialogue. I still see multiple row forms when I hit the ADD button if one is already open.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Subnode grid row close issue [pgAdmin4]
Next
From: Dave Page
Date:
Subject: Re: Control for selecting multiple columns [pgadmin4]