PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.
Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari). Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.
> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote: > > On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala > <murtuza.zabuawala@enterprisedb.com> wrote: >> Yes Dave, I agree that downloading files has been supported in browsers since long . >> >> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself. > > If Safari doesn't support client-side saving of files, then I have to > wonder if our runtime will either - both are webkit based. > > So I guess the next question to ask is; why don't we just generate the > CSV on the server side? >
@Akshay, Can you please suggest on above?
As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.