Re: PATCH: Fix the issue for saving query output as CSV - Mailing list pgadmin-hackers

From Harshal Dhumal
Subject Re: PATCH: Fix the issue for saving query output as CSV
Date
Msg-id CAFiP3vw2WS=XzG_w6EpQYuA0Ww9xt2kLs3J-j2hFmTSpvBsWyQ@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: Fix the issue for saving query output as CSV  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: PATCH: Fix the issue for saving query output as CSV
List pgadmin-hackers
Hi,

PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel.

Changes: To download query result to CSV directly from server and not to use download attr. of anchor tag (<a>) as it's not support by all of major browsers (e.g. Safari).
Also it's not feasible to load data in html to download if result set of query is very huge (in GBs).





-- 
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:


On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Yes, It will not work in runtime as well but I think Neel is working for fix in run time for this issue, We might able to fix it in run time but issue persists in Safari unless they add support in browser itself.

https://webkit.org/status/#feature-download-attribute


> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in browsers since long .
>>
>> But in general we send request & then receives files from web server but in our case we are fetching our data from Backbone models & then converting it to CSV format for downloading as a file at client side in browser itself.
>
> If Safari doesn't support client-side saving of files, then I have to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

   As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again.    

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Attachment

pgadmin-hackers by date:

Previous
From: Surinder Kumar
Date:
Subject: [pgAdmin4][Patch]: Clear query window button click opens query tool in new window in Mac Runtime
Next
From: Surinder Kumar
Date:
Subject: [pgAdmin4][Patch]: RM#1420 - Reverse engineered SQL incomplete for Databases