Re: CREATE SCHEMA IF NOT EXISTS - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: CREATE SCHEMA IF NOT EXISTS
Date
Msg-id CAFcNs+qmQGnvV4e6R3UXyrN9Y4jcnFmno3yJLJ2XBEMgmk4j8w@mail.gmail.com
Whole thread Raw
In response to CREATE SCHEMA IF NOT EXISTS  ("David E. Wheeler" <david@justatheory.com>)
Responses Re: CREATE SCHEMA IF NOT EXISTS
List pgsql-hackers

2012/8/17 Alvaro Herrera <alvherre@2ndquadrant.com>
Excerpts from Dickson S. Guedes's message of vie ago 17 10:37:25 -0400 2012:
> 2012/8/17 Fabrízio de Royes Mello <fabriziomello@gmail.com>:
> >
> > 2012/8/17 Alvaro Herrera <alvherre@2ndquadrant.com>
> >>
> >> Excerpts from Fabrízio de Royes Mello's message of vie ago 17 09:16:30
> >> -0400 2012:
> >>
> >> > The attached patch contains regression tests for it.
> >>
> >> I think you're missing support in copyfuncs.c and equalfuncs.c for the
> >> new field in the node.
> >
> > You're completely right, thanks...
> >
> > The attached patch add support for the new field in the node in
> > "copyfuncs.c" and "equalfuncs.c".
>
> Maybe I'm missing something but shouldn't it being handled in extension.c too?

Please be more explicit?  I don't know what you mean.


Returning conversation to the list.

I think he talked about this piece of code:

diff --git a/src/backend/commands/extension.c b/src/backend/commands/extension.c
index 8512cdb..e359a9c 100644
--- a/src/backend/commands/extension.c
+++ b/src/backend/commands/extension.c
@@ -1374,6 +1374,7 @@ CreateExtension(CreateExtensionStmt *stmt)
                        csstmt->schemaname = schemaName;
                        csstmt->authid = NULL;          /* will be created by current user */
                        csstmt->schemaElts = NIL;
+                       csstmt->if_not_exists = false;
                        CreateSchemaCommand(csstmt, NULL);
 
                        /*

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Blog sobre TI: http://fabriziomello.blogspot.com

Attachment

pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: Planner avoidance of index only scans for partial indexes
Next
From: johnlumby
Date:
Subject: asynchronous disk io (was : tuplesort memory usage)