Re: Remove redundant MemoryContextSwith in BeginCopyFrom - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: Remove redundant MemoryContextSwith in BeginCopyFrom
Date
Msg-id CAFcNs+q+1Qgq-RCL0tGerVcihyWLWAFDL9JybNZ41cN4mjgAQQ@mail.gmail.com
Whole thread Raw
In response to Remove redundant MemoryContextSwith in BeginCopyFrom  (Japin Li <japinli@hotmail.com>)
List pgsql-hackers

On Wed, Jan 19, 2022 at 11:21 AM Japin Li <japinli@hotmail.com> wrote:
>
>
> Hi, hackers
>
> When I read the code of COPY ... FROM ..., I find there is a redundant
> MemoryContextSwith() in BeginCopyFrom().  In BeginCopyFrom, it creates
> a COPY memory context and then switches to it, in the middle of this
> function, it switches to the oldcontext and immediately switches back to
> COPY memory context, IMO, this is redundant, and can be removed safely.
>

LGTM (it passed all regression without any issue)

--
   Fabrízio de Royes Mello         Timbira - http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: New developer papercut - Makefile references INSTALL
Next
From: Bharath Rupireddy
Date:
Subject: Re: Remove redundant MemoryContextSwith in BeginCopyFrom