Re: Review: Non-inheritable check constraints - Mailing list pgsql-hackers

From Alex Hunsaker
Subject Re: Review: Non-inheritable check constraints
Date
Msg-id CAFaPBrS2J0HnsxckVWMMptA4B0MSnTpNM8Rb7FMjYfPd6Q4tLQ@mail.gmail.com
Whole thread Raw
In response to Re: Review: Non-inheritable check constraints  (Nikhil Sontakke <nikkhils@gmail.com>)
Responses Re: Review: Non-inheritable check constraints  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
On Fri, Oct 7, 2011 at 21:30, Nikhil Sontakke <nikkhils@gmail.com> wrote:
> Hi Alex,
>
> I guess we both are in agreement with each other :)
>
> After sleeping over it, I think that check is indeed dead code with this new
> non-inheritable check constraints functionality in place. So unless you have
> some other comments, we can mark this as 'Ready for Commiter'.
>
> Again, thanks for the thorough review and subsequent changes!

PFA an updated patch with the check removed and a comment or two added.

I've also marked it ready.

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Intermittent regression test failure from index-only scans patch
Next
From: Florian Pflug
Date:
Subject: Re: libpq, PQdescribePrepared -> PQftype, PQfmod, no PQnullable