Home > mailing lists

Query Tool JS Minimal Refactoring - Mailing list pgadmin-hackers

From	Yosry Muhammad
Subject	Query Tool JS Minimal Refactoring
Date	August 16, 2019 20:53:10
Msg-id	CAFSMqn8DnxHf7LPLmQOX+8Z6Tivbe59f9MqtYKU2W_JE3T61SA@mail.gmail.com Whole thread Raw
Responses	Re: Query Tool JS Minimal Refactoring (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List	pgadmin-hackers

Hi hackers,

Please find attached a patch with minimal refactoring of:

web/pgadmin/tools/sqleditor/static/js/sqleditor.js

This includes merging 2 redundant functions into one and renaming some functions to have more expressive and consistent names.

Please review !

Thanks.

Yosry Muhammad Yosry

Computer Engineering student,

The Faculty of Engineering,

Cairo University (2021).

Class representative of CMP 2021.

From: Akshay Joshi
Date: 16 August 2019, 15:29:32
Subject: Release next week

From: Akshay Joshi
Date: 17 August 2019, 13:29:07
Subject: pgAdmin 4 commit: Ensure compound triggers for event should be updated