Re: [GSoC] Query History Upgrade - Mailing list pgadmin-hackers

From Yosry Muhammad
Subject Re: [GSoC] Query History Upgrade
Date
Msg-id CAFSMqn-sJZRBLMAzpCk2C=gsF1RveAVMW3wwVphbFMqg22nUxg@mail.gmail.com
Whole thread Raw
In response to Re: [GSoC] Query History Upgrade  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Thanks all for the thorough review.

On Fri, Aug 16, 2019, 1:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks patch applied.

On Wed, Aug 14, 2019 at 7:24 PM Yosry Muhammad <yosrym93@gmail.com> wrote:
Hi,

On Wed, Aug 14, 2019 at 3:50 PM Yosry Muhammad <yosrym93@gmail.com> wrote:
Please find an updated patch with the mentioned issue fixed. I am sorry you spent so much time reviewing this and finding bugs.

On Wed, Aug 14, 2019 at 2:34 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Yosry

I am still facing following issues:
  • No icons for already saved(before applying your patch) query in query history. Is this expected?
I am sorry I missed this, yes this is expected as there is no way to identify internally generated queries before the patch.
Thanks.


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [GSoC] Query History Upgrade
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Add Reverse Engineered SQL tests for Columns. Fixes #