Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: Refactor of the History Tab - Mailing list pgadmin-hackers

From Matthew Kleiman
Subject Re: [pgAdmin4][Patch]: Refactor of the History Tab
Date
Msg-id CAFS4TJZOiP5eEvRacKGmsn0XG2AL9084THNMkf=budtfRcu6qg@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Refactor of the History Tab  (George Gelashvili <ggelashvili@pivotal.io>)
Responses Re: [pgAdmin4][Patch]: Refactor of the History Tab  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
1) I see the font used for class .query-history .entry​ is monospace, shouldn't it be Helvetica as per style guide ? the font for Messages > text is also monospace.

As per Dave's comment, we have added this to the styleguide backlog.  We will be adding monospace entries to the styleguide.

2) Can 1px top border be added above first entry in left panel to differentiate from above panels ?

We have updated the patch to include a 1px solid #cccccc border at the top.  

3) No query execution message appears if i run same query second time, please refer screenshot.

Appears to be fixed with Murtuza's patch.

Thanks,
Sarah and Matt


On Mon, Jul 3, 2017 at 10:05 AM, George Gelashvili <ggelashvili@pivotal.io> wrote:
Hi 
2) Can 1px top border be added above first entry in left panel to differentiate from above panels ?
It sounds like you're describing the distinction between the query history entries and the Messages, History, etc. tab bar (screenshot attached).
If so, the gray/blue contrast should be sufficient to differentiate. 

Thanks,
Shirley and George

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: Allow user to delete Tab via Shift-Tab inquery editor
Next
From: pgAdmin 4 Jenkins
Date:
Subject: Build failed in Jenkins: pgadmin4-master-python35 #218