Postgres Pro
Downloads
Home   >   mailing lists

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions - Mailing list pgsql-hackers

From Ajin Cherian
Subject Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Date
Msg-id CAFPTHDbj_3ZUZGx2oxGvP4mWD14Jsf991K1_ea18E-rB8jrS+w@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions  (Dilip Kumar <dilipbalaut@gmail.com>)
Responses Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
List pgsql-hackers
Tree view


On Wed, Jul 15, 2020 at 2:05 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
  Please see the
latest patch set v33.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com



I have a minor comment. You've defined a new function ReorderBufferStartStreaming() but the function doesn't actually start streaming but is used to find out if you can start streaming and it returns a boolean. Can't you name it accordingly? 
Probably ReorderBufferCanStartStreaming(). I understand that it internally calls ReorderBufferCanStream() which is similar sounding but I think that should not matter.

regards,
Ajin Cherian
Fujitsu Australia

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Support for NSS as a libpq TLS backend
Next
From: Magnus Hagander
Date:
Subject: file_fdw vs relative paths