Re: [PATCH] Preserve replication origin OIDs in pg_upgrade - Mailing list pgsql-hackers

On Thu, Aug 27, 2026 at 3:55 PM Rui Zhao <zhaorui126@gmail.com> wrote:
>
> Hi Ajin,
>
> v17 applies to master (db2d99323f), builds warning-free, make check 245/245,
> pg_upgrade TAP 149/149.  The two upgrades from my last mail still pass, and
> all three points from it are in.
>
> On the commit message: it says commit-timestamp records "are copied
> directly from the old cluster's pg_commit_ts directory", but the copying is
> still the pg_commit_ts migration thread's patch -- so "will be copied"
> would be the accurate tense.
>
> Typo in the comment that replaced the "distinglish" one, at origin.c:309:
> "a status row that exists with remote_ls = 0/0" -> remote_lsn.
>
> Everything else looks good to me.

Addressed these comments and also rebased the patch.

regards,
Ajin Cherian
Fujitsu Australia