Re: Improve pg_sync_replication_slots() to wait for primary to advance - Mailing list pgsql-hackers

On Thu, Dec 4, 2025 at 5:04 PM shveta malik <shveta.malik@gmail.com> wrote:
>
>
> I have just 2 trivial comments for v29-001:
>
> 1)
> -   * receives a SIGINT from the startup process, or when there is an error.
> +   * receives a SIGUSR1 from the startup process, or when there is an error.
>
> In above we should mention stopSignaled rather than SIGUSR1, as
> SIGUSR1 is just a wakeup signal and not termination signal.
>

Fixed.

>  2)
> +    else
> +      ereport(ERROR,
> +          errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
> +          errmsg("cannot continue replication slot synchronization"
> +               " as standby promotion is triggered"));
>
> Please mention that it is SQL-function in the comment for else-block.
>

Fixed.

> ~~
>
> I tested the touched scenarios and here are the LOGs:
>

Thanks for testing!

Attaching patch v30 with the above changes addressed. I've also run
pgindent on the changes.

regards,
Ajin Cherian
Fujitsu Australia