Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: Psycopg3 Fixes - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgAdmin4][Patch]: Psycopg3 Fixes
Date
Msg-id CAFOhELfQdnPVVBL_PoL_6abvR-25+OdLEaBxx3=sp9atZHaaaQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Psycopg3 Fixes  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Akshay,

Please find the patch with the fixes.

On Fri, Oct 21, 2022 at 8:58 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo

I think you forgot to add the python version check in the requirements.txt
psycopg2==2.9.*
psycopg==3.1.0
Fixed. 

Builds are still failing. 

Do we have checks inside the code that if psycopg3 is installed then call the API of psycopg3 else fallback to psycopg2? If not then we should add such checks.

I have put the check in the config file, if the python version is < 3.7 then use psycopg2 otherwise psycopg3.
PEP8 fixes are done. 

Thanks,
Khushboo


On Fri, Oct 21, 2022 at 8:44 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied to the psycopg3 branch

On Thu, Oct 20, 2022 at 2:40 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch which includes the inclusion of psycopg2 again. So, psycopg2 and psycopg3 both are supported. Also, it fixes some of the test cases which were failing.  The debugger test cases fixes work is in progress.

Thanks,
Khushboo


--

Akshay Joshi

Principal Software Architect

+91 9767888246

www.enterprisedb.com




--

Akshay Joshi

Principal Software Architect

+91 9767888246

www.enterprisedb.com


Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: [pgadmin-org/pgadmin4] bf62b9: Update release note.
Next
From: Pravesh Sharma
Date:
Subject: [pgadmin-org/pgadmin4] ad8716: Fixed an issue where the dependents tab wasn't wor...