Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses asynchronous AJAX request - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses asynchronous AJAX request
Date
Msg-id CAFOhELfJzcnLCYAWdVM9PxGJg2jxNyB+Zmotrv9_WWarjHNSmA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses asynchronous AJAX request  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses asynchronous AJAX request  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi,

Please find the attached fix for the same.

Thanks,
Khushboo

On Thu, Jun 22, 2017 at 2:18 PM, Dave Page <dpage@pgadmin.org> wrote:
Hmm, yes - and it's not giving the normal error instructing the user
to set the path, but another one: "Failed to load preference
pg_bin_dir of module paths".

Khushboo, can you investigate and fix ASAP please?

On Thu, Jun 22, 2017 at 9:31 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi Khusboo,
>
> Looks like given change have broken Backup, Restore, Import/Export &
> Maintenance, even if I have binary path set it is throwing an error.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Jun 21, 2017 at 9:40 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Thanks, patch applied!
>>
>> On Wed, Jun 21, 2017 at 12:44 PM, Khushboo Vashi
>> <khushboo.vashi@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > Please find attached patch to fix RM #2487: get_preference() uses a
>> > synchronous AJAX request.
>> >
>> > Introduced the client side caching for preferences to get rid of
>> > synchronous
>> > AJAX request.
>> >
>> >
>> > Thanks,
>> > Khushboo
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Atul Sharma
Date:
Subject: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Moved the javascripts of the following browser nodem