I have reviewed your patch, some modifications are required as below. I have started working on top of your patch to accommodate the required changes.
- Proper handling of Master Password in Server Mode as it was introduced only in Desktop mode.
- Encryption/Decryption of the server password if Master Password is disabled, currently if I disable the master password, I could not connect the server with your patch.
- Proper documentation, comments.
- Minor UI modifications, like introducing a configurable icon with the Oauth login button etc.
On Sun, May 9, 2021 at 12:53 AM Florian Sabonchi <sabonchi@posteo.de> wrote:
Hello in this patch I have implemented OAuth2. Unfortunately I wasn't sure how the test should look like, because I couldn't find anything in the developer documentation, so I decided not to write one for now.
The configuration has to look like this here is an example for github: