Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as. - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.
Date
Msg-id CAFOhELeGU8KJEFLmcwHxOt72aiZQOeXuucDGJfYW6K2=3whevA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.  (Amol Vyavahare <amol.vyavahare@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Amol,

On Wed, Apr 15, 2020 at 12:06 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

I am reviewing this patch.

Thanks,
Khushboo

On Wed, Apr 15, 2020 at 11:45 AM Amol Vyavahare <amol.vyavahare@enterprisedb.com> wrote:
Hi Hackers,
Attached is the patch to fix the Issue with temporary tables on commit drop as. This patch fixes the issue where an error was thrown when the user tried to create a temporary table via query tool and no result was displayed when the query was executed.

Please review.

Please write the API test cases for the same even if the changes are very small but they are in the SQL Editor backend code. 
The patch is working fine and looks good to me.

Thanks,
Khushboo
--
Regards,
Amol Vyavahare
EnterpriseDB Corporation
The Enterprise Postgres Company
T: +91 20 6644 9600, M: +91 738 738 2128
EDB PostgresUnit 301 A, Third Floor, Godrej Castlemaine,
155, Sassoon Road, Pune, MH - 411001
Blog FeedFacebookTwitterLinkedInGoogle+
EnterpriseDB Blog: http://blogs.enterprisedb.com/



pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries
Next
From: Akshay Joshi
Date:
Subject: Re: pgAdmin 4 - next gettext usage fixes