On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:On Wed, Mar 7, 2018 at 9:23 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi Dave,On Wed, Mar 7, 2018 at 7:34 PM, Dave Page <dpage@pgadmin.org> wrote:Khushboo, can you look at this ASAP please? It passed tests on my machine, but Jenkins isn't happy.I have tried to reproduce the issue with many combination but couldn't reproduce it.With the help of logs, I have tried to fix it. Can you please check this fix is helpful or not? On my laptop I now get:======================================================================ERROR: runTest (pgadmin.tools.sqleditor.tests.test_poll_query_tool.TestPollQueryTool)When query tool polling returns messages with result data-set----------------------------------------------------------------------Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py", line 104, in runTest response_data['data']['additional_messages']) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 802, in assertIn if member not in container:TypeError: argument of type 'NoneType' is not iterable---------------------------------------------------------------------- Please provide some more details. Is this failing for particular server version?I am not getting any error with this patch and without this patch on PY2 and PY3 with a single/multiple servers.Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here are the package versions in the venv:alabaster==0.7.10alembic==0.9.6args==0.1.0Babel==2.3.4backports.csv==1.0.4beautifulsoup4==4.4.1blinker==1.3chromedriver-installer==0.0.6click==6.6clint==0.5.1dateutils==0.6.6docutils==0.13.1extras==1.0.0fixtures==3.0.0Flask==0.11.1Flask-Babel==0.11.1Flask-Gravatar==0.4.2Flask-HTMLmin==1.2Flask-Login==0.3.2Flask-Mail==0.9.1Flask-Migrate==2.0.3Flask-Paranoid==0.1.0Flask-Principal==0.4.0Flask-Script==2.0.6Flask-Security==1.7.5Flask-SQLAlchemy==2.1Flask-WTF==0.12funcsigs==1.0.2html5lib==1.0b3htmlmin==0.1.11imagesize==0.7.1importlib==1.0.3itsdangerous==0.24Jinja2==2.7.3linecache2==1.0.0Mako==1.0.7MarkupSafe==0.23minify==0.1.4mock==2.0.0passlib==1.6.2pbr==3.1.1pkginfo==1.4.1psycopg2==2.7.3.2pycodestyle==2.3.1pycrypto==2.6.1Pygments==2.2.0pyperclip==1.5.32pyrsistent==0.14.0python-dateutil==2.5.0python-editor==1.0.3python-mimeparse==1.6.0pytz==2014.10requests==2.13.0requests-toolbelt==0.7.1selenium==3.3.3simplejson==3.6.5six==1.11.0snowballstemmer==1.2.1speaklater==1.3Sphinx==1.5.3SQLAlchemy==1.0.14sqlparse==0.1.19testscenarios==0.5.0testtools==2.0.0traceback2==1.4.0unittest2==1.1.0Werkzeug==0.9.6WTForms==2.0.2yuicompressor==2.4.8-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
On Wed, Mar 7, 2018 at 9:23 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi Dave,On Wed, Mar 7, 2018 at 7:34 PM, Dave Page <dpage@pgadmin.org> wrote:Khushboo, can you look at this ASAP please? It passed tests on my machine, but Jenkins isn't happy.I have tried to reproduce the issue with many combination but couldn't reproduce it.With the help of logs, I have tried to fix it. Can you please check this fix is helpful or not? On my laptop I now get:======================================================================ERROR: runTest (pgadmin.tools.sqleditor.tests.test_poll_query_tool.TestPollQueryTool)When query tool polling returns messages with result data-set----------------------------------------------------------------------Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py", line 104, in runTest response_data['data']['additional_messages']) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 802, in assertIn if member not in container:TypeError: argument of type 'NoneType' is not iterable---------------------------------------------------------------------- Please provide some more details. Is this failing for particular server version?I am not getting any error with this patch and without this patch on PY2 and PY3 with a single/multiple servers.
HiOn Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi Dave,On Wed, Mar 7, 2018 at 7:34 PM, Dave Page <dpage@pgadmin.org> wrote:Khushboo, can you look at this ASAP please? It passed tests on my machine, but Jenkins isn't happy.I have tried to reproduce the issue with many combination but couldn't reproduce it.With the help of logs, I have tried to fix it. Can you please check this fix is helpful or not? On my laptop I now get:======================================================================ERROR: runTest (pgadmin.tools.sqleditor.tests.test_poll_query_tool.TestPollQueryTool)When query tool polling returns messages with result data-set----------------------------------------------------------------------Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py", line 104, in runTest response_data['data']['additional_messages']) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 802, in assertIn if member not in container:TypeError: argument of type 'NoneType' is not iterable----------------------------------------------------------------------
Hi Dave,On Wed, Mar 7, 2018 at 7:34 PM, Dave Page <dpage@pgadmin.org> wrote:Khushboo, can you look at this ASAP please? It passed tests on my machine, but Jenkins isn't happy.I have tried to reproduce the issue with many combination but couldn't reproduce it.With the help of logs, I have tried to fix it. Can you please check this fix is helpful or not?
Khushboo, can you look at this ASAP please? It passed tests on my machine, but Jenkins isn't happy.
pgadmin-hackers by date:
Соглашаюсь с условиями обработки персональных данных