On Tue, Jun 12, 2018 at 9:36 PM, Victoria Henry <vhenry@pivotal.io> wrote:
Hi Khushboo,
The following change is allowing the creation of procedures in postgresql versions less then 11 and also GreenPlum
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/procedure.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/procedure.js
@@ -71,11 +71,7 @@ define('pgadmin.node.procedure', [ if ('catalog' in node_hierarchy) return false;
- // Procedures supported only in PPAS
- return (
- 'server' in node_hierarchy &&
- node_hierarchy['server'].server_type == 'ppas'
- );
+ return true;
Fixed.
Now that the Procedures are a thing in Postgresql maybe they should live in their own module.
The main functionalities of the functions and procedures are almost same and we have inherited most of the things from function itself.
So, as per me they should live in one module.
In the tests for trigger functions we are not consistent on the naming of the utils , in some places we call it funcs_utils in others trigger_funcs_utils.