Re: Pgadmin4 System Stats Extension Design - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: Pgadmin4 System Stats Extension Design
Date
Msg-id CAFOhELdhcYr9NBNrkEAWt_cwP77U2ANRK4xonqKA1p6WpMBdMA@mail.gmail.com
Whole thread Raw
In response to Re: Pgadmin4 System Stats Extension Design  (Sahil Harpal <sahilharpal1234@gmail.com>)
Responses Re: Pgadmin4 System Stats Extension Design
Re: Pgadmin4 System Stats Extension Design
List pgadmin-hackers
Hi Sahil,

Please find the below review comments:

  • Do not use the Title case for the graph/chart’s heading. For example, CPU Usage should be CPU usage. 
  • If I select any database without an extension installed and then select the database with the extension, the message (Extension is not installed) remains on the page. The database change doesn’t reflect on the UI.
  • CPU Usage () - What are these empty parentheses?
  • Please use the same grey background shades on the entire page.
  • Storage tab: If possible, please display the disk name in the heading
  • The Tooltip for graph points remains on the page. Please refer to the below screenshot.

Screenshot 2023-08-17 at 5.50.19 PM.png

  • Please use rounded corners for all the tables (same as graphs).
  • Sometimes graphs start from left and then shift to right. This issue I have reported in my initial review too.
Thanks,
Khushboo



On Thu, Aug 17, 2023 at 3:43 PM Sahil Harpal <sahilharpal1234@gmail.com> wrote:
Hi Khushboo,

I have made the necessary changes and pushed them to the same repository. Let me know if that resolves this null value issue.

Thank you,
Sahil
Attachment

pgadmin-hackers by date:

Previous
From: Sahil Harpal
Date:
Subject: Re: Pgadmin4 System Stats Extension Design
Next
From: Akshay Joshi
Date:
Subject: [pgadmin-org/pgadmin4] eee7e1: Update message catalogs.