Re: pgAdmin4 PATCH: Domain Module - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: pgAdmin4 PATCH: Domain Module
Date
Msg-id CAFOhELdgb566u+4XXOOP4pDCF4GGzK8JZzLrrTuPt=OprsqG5Q@mail.gmail.com
Whole thread Raw
In response to Re: pgAdmin4 PATCH: Domain Module  (Neel Patel <neel.patel@enterprisedb.com>)
Responses Re: pgAdmin4 PATCH: Domain Module  (Neel Patel <neel.patel@enterprisedb.com>)
List pgadmin-hackers
Hi Neel,

Please find updated patch.

Thanks,
Khushboo

On Wed, Jan 20, 2016 at 12:50 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Khushboo,

While applying the patch file, we are getting below warnings.

#########################################
domains (1).patch:1340: trailing whitespace.
          oid: undefined, 
domains (1).patch:1483: trailing whitespace.
    (nspname = 'pg_catalog' AND EXISTS 
domains (1).patch:1487: trailing whitespace.
    OR (nspname = 'information_schema' AND EXISTS 
domains (1).patch:1489: trailing whitespace.
    OR (nspname LIKE '_%' AND EXISTS 
domains (1).patch:1642: trailing whitespace.
 (select 1 from pg_class where relnamespace=typnamespace and relname = typname and relkind != 'c') AND (typname not like '_%' OR NOT EXISTS (select 1 from pg_class where relnamespace=typnamespace and relname = substring(typname from 2)::name and relkind != 'c')) 
warning: squelched 4 whitespace errors
warning: 9 lines add whitespace errors.
#########################################

Can you please remove the whitespace and regenerate the patch ?

Thanks,
Neel Patel

On Wed, Jan 20, 2016 at 12:37 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Resending patch with binary option.

On Wed, Jan 20, 2016 at 10:18 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find attached patch for the Domain Module.

The patch will be modified after Types module implementation as we need to populate Base Type  and some Type related validations from the Types module.

Please review it and let me know the feedback.

Thanks,
Khushboo



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers



Attachment

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: Re: pgAdmin4 PATCH: Domain Module
Next
From: Murtuza Zabuawala
Date:
Subject: Re: PATCH: Login/Group Role Node