Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221 - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221
Date
Msg-id CAFOhELd=61XruRt0epBT-99B97sb7tZcOFx=NbiHvik4SoFeiQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view


On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo

I have reviewed your code and looks good to me. Can we change the message from "The database name is inappropriate" to some meaningful message, so that user should know why it is inappropriate. If user will be able to create database with "=" in name then why Backup, Maintenance and Restore fails.  

Done. Please find the attached updated patch. 
On Wed, May 2, 2018 at 3:44 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch which will fix RMs # 1220 and #1221.

If the database name contains = then the backup, maintenance and restore jobs are failing.
To fix these, we will display the error message regarding inappropriate database name. 

Thanks,
Khushboo



--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel
Next
From: Khushboo Vashi
Date:
Subject: Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221