Postgres Pro
Downloads
Home   >   mailing lists

Re: pgadmin_page functions updated - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: pgadmin_page functions updated
Date
Msg-id CAFOhELcp=g9qyFwOc_4vejbu3TRCC3a0bTYyajifNc5Z8oj7TQ@mail.gmail.com
Whole thread Raw
In response to pgadmin_page functions updated  (Shubham Agarwal <shubham.agarwal@enterprisedb.com>)
Responses Re: pgadmin_page functions updated  (Dave Page <dpage@pgadmin.org>)
Re: pgadmin_page functions updated  (Shubham Agarwal <shubham.agarwal@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Shubham,

On Thu, Jun 14, 2018 at 3:25 PM, Shubham Agarwal <shubham.agarwal@enterprisedb.com> wrote:
Hi Team,

I have modified following two functions in pgadmin_page.py :-

1. click_tab() -> Added wait till element is clickable, test cases are failing since the function attempts to click the tab which is not yet in the state to be clicked.

2. add_server() -> Replaced the sleep statement with wait till element to be clickable. 

Please find the attached patch.

We should start using CSS selectors instead of xpath, otherwise the patch works fine and also changes look good to me.
--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: RM#3294 - User need to reset the layout to see the changedpreferences parameters
Next
From: Shubham Agarwal
Date:
Subject: Re: pgadmin_page functions updated