Re: Pgadmin4 System Stats Extension Design - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: Pgadmin4 System Stats Extension Design
Date
Msg-id CAFOhELcV96_M0PTPGBJ3pEJOqtyA7wPv2u+3KYrf8_4+s7G_4w@mail.gmail.com
Whole thread Raw
In response to Re: Pgadmin4 System Stats Extension Design  (Sahil Harpal <sahilharpal1234@gmail.com>)
Responses Re: Pgadmin4 System Stats Extension Design
List pgadmin-hackers
Hi Sahil,

On Wed, Aug 16, 2023 at 3:25 PM Sahil Harpal <sahilharpal1234@gmail.com> wrote:
I have pushed the recent changes to my GitHub repository. 
If you are still unable to apply the patch, you can pull it from here. In the meantime, I'll check what might be wrong with this patch file.
Can you please fix the below JS error ? Due to this CPU and Memory tabs are not working.
Screenshot 2023-08-17 at 10.35.34 AM.png

Thanks,
Khushboo
 

On Wed, 16 Aug 2023 at 11:51, Sahil Harpal <sahilharpal1234@gmail.com> wrote:
I've noticed something here. I cleared all the errors using 'yarn run bundle:dev,' except for the unused 'counterData' variable, which I'll correct soon. But when I attempted to apply this patch on a freshly cloned repository, it displayed the following warnings. However, it didn't fail, and all the files and folders were created successfully.
image.png
I removed all the whitespaces before creating the patch, and I have also checked all these lines where it is showing the trailing whitespace, but there are no trailing whitespaces. The 'yarn run bundle:dev' command also does not give any prompt for this. Could you please suggest what to do?


On Wed, 16 Aug 2023 at 11:08, Sahil Harpal <sahilharpal1234@gmail.com> wrote:
Could you please try this attached patch.
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: [pgadmin-org/pgadmin4] edd178: Fixed an issue where ignore owner is not working w...
Next
From: Sahil Harpal
Date:
Subject: Re: Pgadmin4 System Stats Extension Design