Postgres Pro
Downloads
Home   >   mailing lists

[HACKERS] Typo in xlogfuncs.c [WAS Re: Incorrect mention of pg_xlog_switch() in xlogfuncs.c] - Mailing list pgsql-hackers

From Neha Khatri
Subject [HACKERS] Typo in xlogfuncs.c [WAS Re: Incorrect mention of pg_xlog_switch() in xlogfuncs.c]
Date
Msg-id CAFO0U+-tO1_gfrsOs9BHv8zHZ9dMA2cFEq4e+4Uxe7=aigknrg@mail.gmail.com
Whole thread Raw
Responses Re: [HACKERS] Typo in xlogfuncs.c [WAS Re: Incorrect mention ofpg_xlog_switch() in xlogfuncs.c]  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Tree view
Simplifying  $subject. There are typos in xlogfuncs.c. So Either

s/pg_xlog_switch/pg_switch_wal

Or

Remove "pg_xlog_switch" from the comments.

Attached patches both ways.

Regards,
Neha

On Sat, May 20, 2017 at 1:08 AM, Neha Khatri <nehakhatri5@gmail.com> wrote:
While reading some code, noticed that the headers of functions
pg_walfile_name_offset() and pg_walfile_name() incorrecty refer
pg_xlog_switch() since the inception of code in commit 704ddaaa.

In PG10 implementation, actual name of the referred function is
pg_switch_wal(). So either refer the correct name in the function
header or remove the other function referral from the function header.


Attachment

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] [BUGS] Concurrent ALTER SEQUENCE RESTART Regression