Re: Per-table storage parameters for TableAM/IndexAM extensions - Mailing list pgsql-hackers

From Sadhuprasad Patro
Subject Re: Per-table storage parameters for TableAM/IndexAM extensions
Date
Msg-id CAFF0-CFSy0wJCTfjJ6QLsHZGfFLAVKiHzgdTJyNnzqJfWpwh7w@mail.gmail.com
Whole thread Raw
In response to Re: Per-table storage parameters for TableAM/IndexAM extensions  (Jelte Fennema <postgres@jeltef.nl>)
Responses Re: Per-table storage parameters for TableAM/IndexAM extensions
List pgsql-hackers
On Mon, Jan 17, 2022 at 4:47 PM Jelte Fennema <postgres@jeltef.nl> wrote:
>
> Big +1, this is a great addition!
>
> I think it would be very useful if there were some tests for this new
> feature. Something similar to the tests for storage parameters for
> index AMs in src/test/modules/dummy_index_am.
>
Sure, I will refer to the index AM test and add the test cases needed.

> Apart from that I think the documentation for table storage parameters
> needs to be updated in doc/src/sgml/ref/create_table.sgml. It now
> needs to indicate that these parameters are different for each table
> access method. Similar to this paragraph in the create index storage
> parameter section of the docs:

Sure, I will add the documentation part for this.

As of now, I have fixed the comments from Dilip & Rushabh and have
done some more changes after internal testing and review. Please find
the latest patch attached.

Thanks & Regards
SadhuPrasad
www.EnterpriseDB.com

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Replace uses of deprecated Python module distutils.sysconfig
Next
From: Andres Freund
Date:
Subject: Re: Adding CI to our tree