Re: Making pg_rewind faster - Mailing list pgsql-hackers

From Srinath Reddy Sadipiralla
Subject Re: Making pg_rewind faster
Date
Msg-id CAFC+b6qemJewRKOmCG83cx_wAXvGPFdMqUtEY8cdwnbV_xu73A@mail.gmail.com
Whole thread Raw
In response to Re: Making pg_rewind faster  (John H <johnhyvr@gmail.com>)
Responses Re: Making pg_rewind faster
List pgsql-hackers
Hi John,

On Tue, Oct 21, 2025 at 3:34 AM John H <johnhyvr@gmail.com> wrote:

> 3) maybe we can improve the error messages for the
> last 2 checks in tap test, that because of this
> reason hence proven that the copy from source to
> target has been done.

What are you thinking of? Something like the below?

+       "Expected WAL segment $corrupt_wal_seg to have been modified
due to rewind");
+       "Expected WAL segment $corrupt_wal_seg to have been synced
from source to target after rewind");

maybe something like this
+ "Expected WAL segment $corrupt_wal_seg to have later mtime
on target than source after rewind as it was copied"); 
+ "Expected WAL segment $corrupt_wal_seg file sizes to be same
between target and source after rewind as it was copied");

--
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master
Next
From: Kirill Reshke
Date:
Subject: Re: Optimize SnapBuildPurgeOlderTxn: use in-place compaction instead of temporary array