> 3) maybe we can improve the error messages for the > last 2 checks in tap test, that because of this > reason hence proven that the copy from source to > target has been done.
What are you thinking of? Something like the below?
+ "Expected WAL segment $corrupt_wal_seg to have been modified due to rewind"); + "Expected WAL segment $corrupt_wal_seg to have been synced from source to target after rewind");
maybe something like this + "Expected WAL segment $corrupt_wal_seg to have later mtime on target than source after rewind as it was copied");
+ "Expected WAL segment $corrupt_wal_seg file sizes to be same between target and source after rewind as it was copied");