The test you added checks that pg_recvlogical creates output files with mode 0640 when the cluster is initialized with group access enabled. However, it does not check the opposite case, i.e., that pg_recvlogical creates output files with mode 0600 when group access is disabled.
It seems we should test both cases, similar to what 010_basebackup.pl does?
As far as I can tell, 010_basebackup.pl initializes the cluster without group access and checks the backup permissions, then enables group access using chmod_recursive() and verifies that group permissions are also applied to the backup. I updated the TAP test following this approach and attached a revised patch.
+1 , I totally missed this case :), patch LGTM.
I'm currently thinking of backpatching the fix itself to all supported branches, but adding the test only to master. Because it does not seem worthwhile to spend much time backporting the test to older branches, where the test code differs much from master. Thought?
