Re: BUG #19491: Segmentation fault triggered by IS NULL - Mailing list pgsql-bugs

From Srinath Reddy Sadipiralla
Subject Re: BUG #19491: Segmentation fault triggered by IS NULL
Date
Msg-id CAFC+b6pKHWbZMYnVmGoFv5hiSgf=_koiTXP-DF+cDZbRo+u-5w@mail.gmail.com
Whole thread
Responses Re: BUG #19491: Segmentation fault triggered by IS NULL
List pgsql-bugs
Hi,

On Fri, Jun 5, 2026 at 9:41 PM Ayush Tiwari <ayushtiwari.slg01@gmail.com> wrote:
Hi,

On Mon, 25 May 2026 at 22:06, Srinath Reddy Sadipiralla <srinath2133@gmail.com> wrote:
Hi,

I have reviewed the patch , i think the error message might be
something like

diff --git a/src/backend/parser/parse_expr.c b/src/backend/parser/parse_expr.c
index 89d0f348303..59e34f082e4 100644
--- a/src/backend/parser/parse_expr.c
+++ b/src/backend/parser/parse_expr.c
@@ -4203,6 +4203,13 @@ transformJsonParseArg(ParseState *pstate, Node *jsexpr, JsonFormat *format,
                                                                                 TEXTOID, -1,
                                                                                 COERCION_IMPLICIT,
                                                                                 COERCE_IMPLICIT_CAST, -1);
+                       if(expr == NULL)
+                               ereport(ERROR,
+                               (errcode(ERRCODE_CANNOT_COERCE),
+                                errmsg("cannot cast type %s to %s",
+                                               format_type_be(*exprtype),
+                                               format_type_be(TEXTOID)),
+                                parser_errposition(pstate, exprLocation(raw_expr))));
                        *exprtype = TEXTOID;
                } 

Thanks, that reads better.  v2 attached, raising ERRCODE_CANNOT_COERCE
right where the coercion fails:

  ERROR:  cannot cast type sqljson_mystr to text

which also covers the JSON() WITH UNIQUE KEYS path.

Thanks for the updated patch, LGTM.
 
--
Thanks :)
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

pgsql-bugs by date:

Previous
From: surya poondla
Date:
Subject: Re: Fw: Re: heap_force_common in contrib/pg_surgery/heap_surgery.c has an off by one stack buffer overflow
Next
From: Xuneng Zhou
Date:
Subject: Re: BUG #18158: Assert in pgstat_report_stat() fails when a backend shutting down with stats pending