Request a Demo
Home   >   mailing lists

Re: [PATCH] Fix pg_rewind false positives caused by shutdown-only WAL - Mailing list pgsql-hackers

From Srinath Reddy Sadipiralla
Subject Re: [PATCH] Fix pg_rewind false positives caused by shutdown-only WAL
Date
Msg-id CAFC+b6oCjWxshOoq=8x+VEwcawYzruKn_FLLFzUxtsgPKe-ozg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Fix pg_rewind false positives caused by shutdown-only WAL  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [PATCH] Fix pg_rewind false positives caused by shutdown-only WAL
List pgsql-hackers
Tree view
Hi Robert,

On Tue, Sep 30, 2025 at 8:08 PM Robert Haas <robertmhaas@gmail.com> wrote:
Hi,

Please stop sending AI-generated messages that you haven't reviewed
for accuracy. You now seem to be conflating what you did or didn't do
with what Srinath did or didn't do.
 
+1
 
Unless BharatDB/Soumya/manimurali
is the same person as Srinath
 
no, i am the original Srinath (SrinathIsVerified) lol.
 

The short version here is that this patch has no future because the
entire premise of it is incorrect. There's no point in sending another
version ever, as far as I can see. If you or anyone else disagrees, we
should talk about that.

Can you please once confirm this, did you mean that this is not even an actual problem to fix or only this patch's logic which I provided does not make sense?, because i am trying out come up with another patch based on your inputs regarding considering controlfile changes , ignoring RUNNING_XACTS records, and to use XLogRecGetRmid test.


--
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: The ability of postgres to determine loss of files of the main fork
Next
From: Tom Lane
Date:
Subject: Re: Why cannot alter column type when a view depends on it?