Re: Improving the heapgetpage function improves performance in common scenarios - Mailing list pgsql-hackers

From John Naylor
Subject Re: Improving the heapgetpage function improves performance in common scenarios
Date
Msg-id CAFBsxsEsd-UtnvyCXWB3rEOxB17TJvdVMYgSB=3OWk3zOYi5FA@mail.gmail.com
Whole thread Raw
In response to Re: Improving the heapgetpage function improves performance in common scenarios  (Quan Zongliang <quanzongliang@yeah.net>)
Responses Re: Improving the heapgetpage function improves performance in common scenarios
List pgsql-hackers

On Wed, Sep 6, 2023 at 2:50 PM Quan Zongliang <quanzongliang@yeah.net> wrote:

> If not optimized(--enable-debug CFLAGS='-O0'), there is a clear
> difference. When the compiler does the optimization, the performance is
> similar. I think the compiler does a good enough optimization with
> "pg_attribute_always_inline" and the last two constant parameters when
> calling heapgetpage_collect.

So as we might expect, more specialization (Andres' patch) has no apparent downsides in this workload. (While I'm not sure of the point of testing at -O0, I think we can conclude that less-bright compilers will show some improvement with either patch.)

If you agree, do you want to withdraw your patch from the commit fest?

--
John Naylor
EDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [PoC] pg_upgrade: allow to upgrade publisher node
Next
From: Richard Guo
Date:
Subject: Re: Introduce join_info_array for direct lookups of SpecialJoinInfo by ojrelid