On Mon, Sep 5, 2022 at 1:18 AM Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> On 2022-09-04 12:16:10 +0700, John Naylor wrote:
> > Pushed 01 and 02 separately, then squashed and pushed the rest.
>
> Thanks a lot! It does look a good bit cleaner to me now.
>
> I think, as a followup improvement, we should move gramparse.h to
> src/backend/parser, and stop installing gram.h, gramparse.h. gramparse.h
> already had this note:
>
> * NOTE: this file is only meant to be included in the core parsing files,
> * i.e., parser.c, gram.y, and scan.l.
> * Definitions that are needed outside the core parser should be in parser.h.
>
> What do you think?
+1 for the concept, but haven't looked at the details.
--
John Naylor
EDB: http://www.enterprisedb.com
