Hi Japin,
On Fri, Sep 25, 2026 at 8:25 PM Japin Li <japinli@hotmail.com> wrote:
>
> In the v4-0001 commit message, it says no behavior change. However, it seems
> an Assert introduced after setting vartag.
>
Fair. The assertion cannot fire (both callers pass a constant tag)
and is compiled out without --enable-cassert, but I'll mention it in
the commit message next time.
> Since the access/detoast.h include the access/toast_compression.h, should we remove
> the access/toast_compression.h in files that already include access/toash.h?
>
I'd keep them. All six files use toast_compression.h symbols
directly, and the convention is to include what you use rather than
rely on a transitive include (src/tools/pginclude/README). detoast.h
includes it for its own field, and e27f3b2cad7 added these includes to
exactly these files for the same reason.
--
Nikhil Veldanda
