Hi all,
Thank you for the updated patch.
I reviewed and tested the patch for including sequences in
publications created by pg_createsubscriber. The patch correctly
changes the internally generated publication from FOR ALL TABLES to
FOR ALL TABLES, ALL SEQUENCES. I also verified the changes in the test
and documentation, including the handling of sequence synchronization
through REFRESH SEQUENCES. I tested the patch with the
pg_createsubscriber TAP tests and the relevant build/tests passed
successfully. I also performed a manual test by converting a physical
standby using pg_createsubscriber and verified from the generated
internal log that the publication command contains both FOR ALL TABLES
and ALL SEQUENCES. The conversion completed successfully. Overall, the
implementation looks correct and the observed behavior is as expected.
The patch looks good to me.
Regards
Solai
