Re: Correct comment wording in extension.c - Mailing list pgsql-hackers

From albert tan
Subject Re: Correct comment wording in extension.c
Date
Msg-id CAEzort=tx6LsEwY8mpBZ9A9uUa80FZsHcbHzgaX=NSCMeB_tzQ@mail.gmail.com
Whole thread Raw
In response to 回复: Correct comment wording in extension.c  (li carol <carol.li2025@outlook.com>)
List pgsql-hackers


On Fri, Jan 9, 2026 at 2:17 PM li carol <carol.li2025@outlook.com> wrote:

>On Wed, Jan 7, 2026 at 1:13PM albert tan <alterttan1223@gmail.com> wrote:
>Hi Join,
>Thanks for pointing out extra issues. I have addressed them in v2.

 

Hi Albert, John,

 

In addition to the previous findings, I went through src/backend/commands/extension.c again and identified other spots that need adjustment for better clarity and grammar.

In the header for find_in_paths:

/*

* Work in a very similar way with find_in_path but it receives an already

* parsed List of paths to search the basename and it do not support macro

* replacement or custom error messages (for simplicity).

*

* By "already parsed List of paths" this function expected that paths already

* have all macros replaced.

*/

 

This should be corrected to:

"Works in a very similar way to find_in_path, but it receives an already parsed List of paths to search the basename, and it does not support macro replacement or custom error messages (for simplicity). By 'already parsed List of paths' this function expects that the paths already have all macros replaced."

 

I hope this helps in making the file more consistent.

 

Best regards,

Yuan Li(carol)


 Hi Carol, John
Thanks for pointing out extra issues. I have addressed them in v3. 
Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: proposal: schema variables
Next
From: Amit Kapila
Date:
Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup