Re: Combine pg_walinspect till_end_of_wal functions with others - Mailing list pgsql-hackers

From Matthias van de Meent
Subject Re: Combine pg_walinspect till_end_of_wal functions with others
Date
Msg-id CAEze2WjiG4QKoXJi5aN-F8C4T7jz=--+jB4OJz48+GjdP0+f7A@mail.gmail.com
Whole thread Raw
In response to Re: Combine pg_walinspect till_end_of_wal functions with others  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Combine pg_walinspect till_end_of_wal functions with others
List pgsql-hackers
On Mon, 6 Mar 2023 at 16:06, Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
> If we try to make these functions figure out the oldest WAl file and
> start from there, then it'll unnecessarily complicate the APIs and
> functions. If we still think we need a better function for the users
> to figure out the oldest WAL file, perhaps, add a SQL-only
> view/function to pg_walinspect that returns "select name from
> pg_ls_waldir() order by name limit 1;", but honestly, that's so
> trivial.

That "order by name limit 1" has subtle bugs when you're working on a
system that has experienced timeline switches. It is entirely possible
that the first file (as sorted by the default collation) is not the
first record you can inspect, or even in your timeline's history.


Kind regards,

Matthias van de Meent



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: wrong results due to qual pushdown
Next
From: Andrew Dunstan
Date:
Subject: Re: meson: Optionally disable installation of test modules