Re: Is the XLP_BKP_REMOVABLE flag itself removable/obsolete? - Mailing list pgsql-hackers

From Matthias van de Meent
Subject Re: Is the XLP_BKP_REMOVABLE flag itself removable/obsolete?
Date
Msg-id CAEze2WhJThcajjanXoQGC3BuAGqkcSeLZMZL6z+6OZp+oHDbng@mail.gmail.com
Whole thread
In response to Re: Is the XLP_BKP_REMOVABLE flag itself removable/obsolete?  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Mon, 2 Mar 2026 at 06:20, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Feb 27, 2026 at 08:15:22AM +0900, Michael Paquier wrote:
> > Let's just remove this flag.  I would have let XLP_ALL_FLAGS as it is
> > now at 0x000F, though.  It is just used for filtering the bits we
> > allow to exist in this area of the header, for validation.  Perhaps
> > some forks like this extensibility if they have their own extra custom
> > bits, meaning less code to modify.  That's a minor point for sure, but
> > people like hacking on Postgres and forking this code.
>
> Done.  The patch missed a variable declaration not required anymore in
> AdvanceXLInsertBuffer(), that I have caught with a compiler warning.

Thanks for the check, clean up, and commit!


Kind regards,

Matthias van de Meent
Databricks (https://www.databricks.com)



pgsql-hackers by date:

Previous
From: VASUKI M
Date:
Subject: Re: [PATCH] psql: tab completion for ALTER ROLE ... IN DATABASE ...
Next
From: Tomas Vondra
Date:
Subject: Re: index prefetching