Re: Avoid possible dereference null pointer (src/backend/catalog/pg_depend.c) - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: Avoid possible dereference null pointer (src/backend/catalog/pg_depend.c)
Date
Msg-id CAExHW5vvX-D1srDzCpATc-L1DdsvJfYr6+K0eqsjNq7C5nbKKA@mail.gmail.com
Whole thread Raw
In response to Re: Avoid possible dereference null pointer (src/backend/catalog/pg_depend.c)  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Avoid possible dereference null pointer (src/backend/catalog/pg_depend.c)
List pgsql-hackers


On Fri, May 24, 2024 at 12:16 PM Michael Paquier <michael@paquier.xyz> wrote:
On Fri, May 24, 2024 at 11:58:51AM +0530, Ashutosh Bapat wrote:
> If we are looking for avoiding a segfault and get a message which helps
> debugging, using get_attname and get_attnum might be better options.
> get_attname throws an error. get_attnum doesn't throw an error and returns
> InvalidAttnum which won't return any valid identity sequence, and thus
> return a NIL sequence list which is handled in that function already. Using
> these two functions will avoid the clutter as well as segfault. If that's
> acceptable, I will provide a patch.

Yeah, you could do that with these two routines as well.  The result
would be the same in terms of runtime validity checks.

PFA patch using those two routines. 

--
Best Wishes,
Ashutosh Bapat
Attachment

pgsql-hackers by date:

Previous
From: Dmitry Dolgov
Date:
Subject: Re: Schema variables - new implementation for Postgres 15
Next
From: Ranier Vilela
Date:
Subject: Re: Avoid possible dereference null pointer (src/backend/catalog/pg_depend.c)